New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dashboard title and description with React #4739

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Apr 19, 2018

Backport of #4730 for 2.4

Handle editing of dashboard title and description through React and
Reflux, avoiding the use of jquery and specially .html

(cherry picked from commit 5fbb7d3)

@dennisoelkers dennisoelkers added this to the 2.4.4 milestone Apr 19, 2018

@edmundoa edmundoa self-assigned this Apr 19, 2018

<LinkContainer to={Routes.dashboard_show(this.props.dashboard.id)}>
<a><span ref="dashboardTitle">{this.props.dashboard.title}</span></a>
</LinkContainer>
<Link to={Routes.dashboard_show(this.props.dashboard.id)}>{this.props.dashboard.title}</Link>

This comment has been minimized.

@edmundoa

edmundoa Apr 19, 2018

Member

Link is not imported in the file. Since 2.4 uses a different react-router version than 3.0, I would keep the old LinkContainer component and play it safe.

This comment has been minimized.

@dennisoelkers

dennisoelkers Apr 20, 2018

Member

Good point! 👍

Set dashboard title and description with React (#4730)
Handle editing of dashboard title and description through React and
Reflux, avoiding the use of jquery and specially `.html`

(cherry picked from commit 5fbb7d3)

@dennisoelkers dennisoelkers force-pushed the simplify-dashboard-update-2.4 branch from eaf7427 to 535689c Apr 20, 2018

@edmundoa

LGTM 👍

@edmundoa edmundoa merged commit 4a34665 into 2.4 Apr 20, 2018

4 of 5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 2459 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 1301 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@edmundoa edmundoa deleted the simplify-dashboard-update-2.4 branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment