Set dashboard title and description with React #4739
Merged
Conversation
<LinkContainer to={Routes.dashboard_show(this.props.dashboard.id)}> | ||
<a><span ref="dashboardTitle">{this.props.dashboard.title}</span></a> | ||
</LinkContainer> | ||
<Link to={Routes.dashboard_show(this.props.dashboard.id)}>{this.props.dashboard.title}</Link> |
edmundoa
Apr 19, 2018
Member
Link
is not imported in the file. Since 2.4 uses a different react-router version than 3.0, I would keep the old LinkContainer
component and play it safe.
Link
is not imported in the file. Since 2.4 uses a different react-router version than 3.0, I would keep the old LinkContainer
component and play it safe.
dennisoelkers
Apr 20, 2018
Author
Member
Good point! 👍
Good point!
Handle editing of dashboard title and description through React and Reflux, avoiding the use of jquery and specially `.html` (cherry picked from commit 5fbb7d3)
eaf7427
to
535689c
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Backport of #4730 for 2.4
Handle editing of dashboard title and description through React and
Reflux, avoiding the use of jquery and specially
.html
(cherry picked from commit 5fbb7d3)