Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSet dashboard title and description with React #4739
Conversation
dennisoelkers
added
the
ready-for-review
label
Apr 19, 2018
dennisoelkers
added this to the 2.4.4 milestone
Apr 19, 2018
edmundoa
self-assigned this
Apr 19, 2018
| <LinkContainer to={Routes.dashboard_show(this.props.dashboard.id)}> | ||
| <a><span ref="dashboardTitle">{this.props.dashboard.title}</span></a> | ||
| </LinkContainer> | ||
| <Link to={Routes.dashboard_show(this.props.dashboard.id)}>{this.props.dashboard.title}</Link> |
This comment has been minimized.
This comment has been minimized.
edmundoa
Apr 19, 2018
Member
Link is not imported in the file. Since 2.4 uses a different react-router version than 3.0, I would keep the old LinkContainer component and play it safe.
This comment has been minimized.
This comment has been minimized.
dennisoelkers
force-pushed the
simplify-dashboard-update-2.4
branch
from
eaf7427
to
535689c
Apr 20, 2018
edmundoa
merged commit 4a34665
into
2.4
Apr 20, 2018
4 of 5 checks passed
ci-web-linter
Jenkins build graylog-pr-linter-check 2459 has failed
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
graylog-project/pr
Jenkins build graylog-project-pr-snapshot 1301 has succeeded
Details
license/cla
Contributor License Agreement is signed.
Details
edmundoa
deleted the
simplify-dashboard-update-2.4
branch
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dennisoelkers commentedApr 19, 2018
Backport of #4730 for 2.4
Handle editing of dashboard title and description through React and
Reflux, avoiding the use of jquery and specially
.html(cherry picked from commit 5fbb7d3)