Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintaining saved search id across search execution. #4743

Merged
merged 1 commit into from Apr 20, 2018
Merged

Maintaining saved search id across search execution. #4743

merged 1 commit into from Apr 20, 2018

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Apr 20, 2018

Description

Motivation and Context

Before this change, the saved search id which was selected on the search page was reset after the next search execution. This prevented any updates to saved searches, as updating the query took effect only after the next search execution.

With this change, a selected saved search id is added as a hidden field to the search query form, so it is maintained across search executions. This allows the user to select a saved search, modify the query and update the saved search afterwards.

Fixes #2285.

Needs to be merged into master as well.

How Has This Been Tested?

Manual testing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@dennisoelkers dennisoelkers added this to the 2.4.4 milestone Apr 20, 2018
@dennisoelkers dennisoelkers requested a review from edmundoa Apr 20, 2018
Copy link
Member

@edmundoa edmundoa left a comment

LGTM 👍

@edmundoa edmundoa merged commit 7fce24c into 2.4 Apr 20, 2018
4 of 5 checks passed
4 of 5 checks passed
ci-web-linter Jenkins build graylog-pr-linter-check 2461 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 1303 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the issue-2285 branch Apr 20, 2018
edmundoa added a commit that referenced this pull request Apr 20, 2018
(cherry picked from commit 7fce24c)
dennisoelkers added a commit that referenced this pull request Apr 20, 2018
(cherry picked from commit 7fce24c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants