New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort output config fields stably #4755

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
2 participants
@Al2Klimov
Contributor

Al2Klimov commented Apr 23, 2018

Description

refs #4745

Motivation and Context

#4746 (comment)

How Has This Been Tested?

Not at all. Unfortunately I couldn't build Graylog independent of my change.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@edmundoa edmundoa self-requested a review Apr 25, 2018

@edmundoa edmundoa self-assigned this Apr 25, 2018

@edmundoa

This comment has been minimized.

Member

edmundoa commented Apr 25, 2018

Thank you for backporting your PR! Let's work on the code in #4746 and later update this with the final result. In that way it is less work and also clearer to follow the changes.

@Al2Klimov Al2Klimov force-pushed the Al2Klimov:bugfix/config-sort-stable-2.4 branch from 297fa3d to e2d8931 Apr 25, 2018

@Al2Klimov

This comment has been minimized.

Contributor

Al2Klimov commented Apr 25, 2018

Done.

@edmundoa

LGTM 👍

@edmundoa edmundoa merged commit 3d6d8e7 into Graylog2:2.4 Apr 25, 2018

3 of 4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 2485 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 1329 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@edmundoa

This comment has been minimized.

Member

edmundoa commented Apr 25, 2018

Thank you again for your contribution @Al2Klimov!

@edmundoa edmundoa added this to the 2.4.4 milestone Apr 25, 2018

@Al2Klimov Al2Klimov deleted the Al2Klimov:bugfix/config-sort-stable-2.4 branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment