Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Support case-insensitive auth-scheme token in proxy authentication #4790
The original implementation of the
The original implementation of the `ProxyAuthenticator` in `OkHttpClientProvider` matched the authentication scheme in a case-sensitive way, which doesn't work with all HTTP proxy servers in the wild. Fixes #4788 Reference: RFC 7235, section 2.1 > Authentication parameters are name=value pairs, where the name token > is matched case-insensitively, and each parameter name MUST only > occur once per challenge. https://tools.ietf.org/html/rfc7235#section-2.1 RFC 2617, section 1.2 > It [the authentication mechanism] uses an extensible, > case-insensitive token to identify the authentication scheme, > followed by a comma-separated list of attribute-value pairs which > carry the parameters necessary for achieving authentication via that > scheme. https://tools.ietf.org/html/rfc2617#section-1.2