New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update positions after click in widget actions #4808

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented May 28, 2018

Clicking anywhere on an unlocked widget generates a drag event, which in our case ends up sending a request to the server to update widgets positions. This also affects buttons that are meant to do other actions (like delete or edit widgets), making #4525 more likely to appear.

This PR is a partial backport of #4530, only including changes to avoid calling drag callbacks when a user clicks on the edit or delete buttons for a widget, which mitigates #4525.

Fixes #4525

PS: The issue seems to be way more likely to occur in Google Chrome than other browsers, so it's easier to reproduce the issue in that browser.

Do not update positions after click in widget actions
Clicking anywhere on an unlocked widget generates a drag event, which in
our case ends up sending a request to the server to update widgets
positions.
Use React Grid Layout `draggableCancel` prop, to avoid calling drag
callbacks when a user clicks on the edit or delete buttons for a widget.

Partial backport of 9488608 (#4530).
Mitigates #4525

@edmundoa edmundoa added this to the 2.4.5 milestone May 28, 2018

@bernd bernd self-assigned this May 28, 2018

@bernd

bernd approved these changes May 28, 2018

LGTM 👍

@bernd bernd merged commit 808727d into 2.4 May 28, 2018

4 of 5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 2522 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 1396 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the issue-4525-2.4 branch May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment