Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Preventing index size/time input to hide rotation strategy dropdown. #4826
Motivation and Context
Before this change, other elements (namely react-bootstrap input
This change is increasing the
Should be backported to
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Maybe, maybe not. This happens only when two things are combined:
To "fix" it in a general way, we would have to normalize the z-index of b) to 0 globally. I would not do that right now, because we have only a single form where it broke, and I am sure it has been set to 2 in
I was looking into a similar issue that @bernd found in #4828, and investigating a bit I found the culprit of this behaviour, which is a change in react-select: JedWatson/react-select@b0bc3e3#diff-895b3c670e6ebd76e91dbce59ff14fdb
I think using a low z-index value by default in the library makes sense, so I think the best way we can solve this issue is increasing the react-select's z-index in our component, as they suggest there. In that way we can set a higher value than the one used by react-bootstrap or ace editor, ensuring the option list will appear above other inputs.