Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for permission before terminating input. #4867

Merged
merged 1 commit into from Jun 28, 2018
Merged

Check for permission before terminating input. #4867

merged 1 commit into from Jun 28, 2018

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jun 26, 2018 •
edited

Description

Motivation and Context

Before this change it was possible to terminate any input for every
authenticated user. This change introduces a check for the
inputs:terminate:<input id> permission before terminating an input.

Might be backported to 2.4.

Fixes #4858.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dennisoelkers
Check for permission before terminating input.
e703dae 
Before this change it was possible to terminate any input for every
authenticated user. This change introduces a check for the
`inputs:terminate:<input id>` permission before terminating an input.

Fixes #4858.
@dennisoelkers dennisoelkers added this to the 3.0.0 milestone Jun 26, 2018
@bernd bernd self-assigned this Jun 27, 2018
@bernd bernd merged commit 0582e31 into master Jun 28, 2018
@bernd bernd deleted the issue-4858 branch June 28, 2018 06:17
bernd pushed a commit that referenced this pull request Jun 28, 2018
@dennisoelkers @bernd
Check for permission before terminating input. (#4867)
76ec688 
Before this change it was possible to terminate any input for every
authenticated user. This change introduces a check for the
`inputs:terminate:<input id>` permission before terminating an input.

Fixes #4858.

(cherry picked from commit 0582e31)
dennisoelkers pushed a commit that referenced this pull request Jun 28, 2018
@bernd @dennisoelkers
Check for permission before terminating input. (#4867) (#4874)
9618d75 
Before this change it was possible to terminate any input for every
authenticated user. This change introduces a check for the
`inputs:terminate:<input id>` permission before terminating an input.

Fixes #4858.

(cherry picked from commit 0582e31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernd bernd bernd approved these changes

Assignees

@bernd bernd

Labels
bug ready-for-review security
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Check for user permission before delete input resource
2 participants
@dennisoelkers @bernd