Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search query in alert conditions configurable in the UI (#5212) #5277

merged 1 commit into from Nov 8, 2018


Copy link

@edmundoa edmundoa commented Nov 7, 2018

Cherry-pick of #5212 into 2.5

* Make search query in alert conditions configurable in the UI

This exposes a new query config field in the alert condition
configuration. The value defaults to "*".

The query is used to build a filter string for the alert condition
search. We add the query string to the query filter for performance

Fixes #3966

* Trim streamId and query strings

* Use query config in field content value condition as well

* Add HTTP API endpoints to test alert conditions

There are two test endpoints, one to test existing alert conditions and
one to test new alert conditions which have not been stored in the
database yet.

* Add missing NoAuditEvent annotations to test resources

* Fix failing test because of missing stream id

* Use AND operator and parentheses to combine streams and custom query

Otherwise the generated query will be wrong.

(cherry picked from commit 0533cfd)
@edmundoa edmundoa added this to the 2.5.0 milestone Nov 7, 2018
@edmundoa edmundoa requested a review from bernd Nov 7, 2018
bernd approved these changes Nov 8, 2018
@bernd bernd merged commit bbe7fdf into 2.5 Nov 8, 2018
2 of 3 checks passed
2 of 3 checks passed
ci-web-linter Jenkins build graylog-pr-linter-check 2943 has failed
graylog-project/pr Jenkins build graylog-project-pr-snapshot 2170 has succeeded
license/cla Contributor License Agreement is signed.
@bernd bernd deleted the issue-3966-2.5 branch Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants