Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Backslash Escaping for Phrase Searches (#4477) #5314

Merged
merged 1 commit into from Nov 26, 2018
Merged

Fix Backslash Escaping for Phrase Searches (#4477) #5314

merged 1 commit into from Nov 26, 2018

Conversation

@bernd
Copy link
Member

@bernd bernd commented Nov 26, 2018

The add search term button (eg. in the Quick Values view)
is adding search terms to the search bar. A search term
with spaces will be treated as a phrase and therefor will
only surrounded by double quotes. But those phrases did
not escape backslashes which is still needed to perform
the search.

Now phrases will also get the backslashes escaped.

Also: Add some tests for adding a search term.

Fixes #4111
Fixes #5266

(cherry picked from commit bfc4a9f)

The add search term button (eg. in the Quick Values view)
is adding search terms to the search bar. A search term
with spaces will be treated as a phrase and therefor will
only surrounded by double quotes. But those phrases did
not escape backslashes which is still needed to perform
the search.

Now phrases will also get the backslashes escaped.

Also: Add some tests for adding a search term.

Fixes #4111
Fixes #5266

(cherry picked from commit bfc4a9f)
@bernd bernd added this to the 2.5.0 milestone Nov 26, 2018
@bernd bernd requested a review from edmundoa Nov 26, 2018
@edmundoa edmundoa merged commit b034db6 into 2.5 Nov 26, 2018
2 of 3 checks passed
2 of 3 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 3006 has failed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 2266 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the issue-5266 branch Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants