Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-completion in several drop-down fields #5665

Merged
merged 1 commit into from May 16, 2019

Conversation

@bernd
Copy link
Member

commented Feb 8, 2019

In all these cases the matchProp needs to be set to "label" and not "value"
because the value contains the object ID or another identifier.

After this, the auto-completion is looking at same data that the user
is seeing.

Fixes #5659

@bernd bernd added this to the 3.1.0 milestone Feb 8, 2019

Fix auto-completion in several drop-down fields
In all these cases the matchProp needs to be set to "label" and not "value"
because the value contains the object ID or another identifier.

After this, the auto-completion is looking at same data that the user
is seeing.

Fixes #5659

@bernd bernd force-pushed the issue-5659 branch from 51d4481 to fbb6923 Apr 10, 2019

@deeshe deeshe removed this from the 3.1.0 milestone Apr 25, 2019

@danotorrey danotorrey self-requested a review May 3, 2019

@danotorrey

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

I am going to work on fixing up these linter errors.

@bernd

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

@danotorrey I think we shouldn't do that for this PR. There are a lot of unrelated linter errors and fixing them here would only mixup the actual issue fix with linter fixes.

@danotorrey

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@bernd Good point. Thanks. I'll ignore those for now.

@danotorrey
Copy link
Contributor

left a comment

LGTM

@danotorrey danotorrey merged commit 62587c0 into master May 16, 2019

3 of 4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3528 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3676 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@danotorrey danotorrey deleted the issue-5659 branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.