Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show an "(optional)" for boolean configuration fields #5678

Merged
merged 1 commit into from Mar 22, 2019

Conversation

@mpfz0r
Copy link
Member

commented Feb 13, 2019

Booleans are always optional and in some cases, the text leads
to confusion.
For example, on a checkbox named [x] Enable TLS (optional) the user
could expect that non working TLS will fallback to plaintext,
which is not the case.

Do not show an "(optional)" for boolean configuration fields
Booleans are always optional and in some cases, the text leads
to confusion.
For example, on a checkbox named `[x] Enable TLS (optional)` the user
could expect that non working TLS will fallback to plaintext,
which is not the case.
@kmerz
kmerz approved these changes Mar 22, 2019
Copy link
Member

left a comment

LGTM 👍 tested on several pages!

@kmerz kmerz merged commit 1cea0c3 into master Mar 22, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3359 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3101 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kmerz kmerz deleted the no-optional-marker-for-bools branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.