Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double prefixing paths for navigation items in system menu. #5703

Merged
merged 2 commits into from Feb 26, 2019

Conversation

Projects
None yet
2 participants
@dennisoelkers
Copy link
Member

dennisoelkers commented Feb 20, 2019

Description

Motivation and Context

In #5193, the newly created NavigationLink component performs
prefixing the path passed to it with the application prefix. This is
happening although in Routes.jsx all routes are already being prefixed
before being exported.

This change is removing the prefixing in NavigationLink.

Fixes #5702.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Prevent double prefixing paths for navigation items in system menu.
In #5193, the newly created `NavigationLink` component performs
prefixing the path passed to it with the application prefix. This is
happening although in `Routes.jsx` all routes are already being prefixed
before being exported.

This change is removing the prefixing in `NavigationLink`.

Fixes #5702.

@dennisoelkers dennisoelkers added this to the 3.1.0 milestone Feb 20, 2019

@kmerz kmerz self-requested a review Feb 25, 2019

@kmerz

kmerz approved these changes Feb 25, 2019

Copy link
Member

kmerz left a comment

Coded reviewd. Looks good to me! 👍

@kmerz

This comment has been minimized.

Copy link
Member

kmerz commented Feb 26, 2019

Tested by @jalogisch 👍

@kmerz kmerz merged commit bcf53ec into master Feb 26, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3386 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3166 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kmerz kmerz deleted the issue-5702 branch Feb 26, 2019

dennisoelkers added a commit that referenced this pull request Mar 12, 2019

Prevent double prefixing paths for navigation items in system menu.
This PR is backporting #5703 to `3.0`.

In #5193, the newly created `NavigationLink` component performs
prefixing the path passed to it with the application prefix. This is
happening although in `Routes.jsx` all routes are already being prefixed
before being exported.

This change is removing the prefixing in `NavigationLink`.

Fixes #5702.

(cherry picked from commit bcf53ec)

kmerz added a commit that referenced this pull request Mar 14, 2019

Prevent double prefixing paths for navigation items in system menu. (#…
…5765)

This PR is backporting #5703 to `3.0`.

In #5193, the newly created `NavigationLink` component performs
prefixing the path passed to it with the application prefix. This is
happening although in `Routes.jsx` all routes are already being prefixed
before being exported.

This change is removing the prefixing in `NavigationLink`.

Fixes #5702.

(cherry picked from commit bcf53ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.