Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP 100 handling in http inputs #5725

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@mpfz0r
Copy link
Member

mpfz0r commented Feb 26, 2019

Requests with Expect: 100-Continue would lead to an exception and
terminate the request.
This got broken with the netty upgrade, which exchanged the
HttpChunkedAggregator to the new HttpObjectAggregator.

The aggregator needs to be registered after the HttpResponseEncoder
in the ChannelPipeline.
Ref: https://netty.io/4.1/api/io/netty/handler/codec/http/HttpObjectAggregator.html

Fixes #5690

Fix HTTP 100 handling in http inputs
Requests with `Expect: 100-Continue` would lead to an exception and
terminate the request.
This got broken with the netty upgrade, which exchanged the
`HttpChunkedAggregator` to the new `HttpObjectAggregator`.

The aggregator needs to be registered after the `HttpResponseEncoder`
in the ChannelPipeline.
Ref: https://netty.io/4.1/api/io/netty/handler/codec/http/HttpObjectAggregator.html

Fixes #5690

@mpfz0r mpfz0r added this to the 3.0.1 milestone Feb 26, 2019

@mpfz0r mpfz0r requested a review from bernd Feb 26, 2019

@dennisoelkers dennisoelkers self-assigned this Mar 13, 2019

@dennisoelkers dennisoelkers merged commit bc4301f into master Mar 13, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3396 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3192 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@dennisoelkers dennisoelkers deleted the issue-5690 branch Mar 13, 2019

mpfz0r added a commit that referenced this pull request Mar 13, 2019

Fix HTTP 100 handling in http inputs (#5725)
Requests with `Expect: 100-Continue` would lead to an exception and
terminate the request.
This got broken with the netty upgrade, which exchanged the
`HttpChunkedAggregator` to the new `HttpObjectAggregator`.

The aggregator needs to be registered after the `HttpResponseEncoder`
in the ChannelPipeline.
Ref: https://netty.io/4.1/api/io/netty/handler/codec/http/HttpObjectAggregator.html

Fixes #5690

(cherry picked from commit bc4301f)

dennisoelkers added a commit that referenced this pull request Mar 13, 2019

Fix HTTP 100 handling in http inputs (#5725) (#5768)
Requests with `Expect: 100-Continue` would lead to an exception and
terminate the request.
This got broken with the netty upgrade, which exchanged the
`HttpChunkedAggregator` to the new `HttpObjectAggregator`.

The aggregator needs to be registered after the `HttpResponseEncoder`
in the ChannelPipeline.
Ref: https://netty.io/4.1/api/io/netty/handler/codec/http/HttpObjectAggregator.html

Fixes #5690

(cherry picked from commit bc4301f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.