Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http input keep-alive handling #5728

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@mpfz0r
Copy link
Member

mpfz0r commented Feb 27, 2019

We were only responding to the first request on an http keep-alive connection with a 202.
Any following requests would not be answered, leading to a timeout in the client.

Configuring a ChannelFuture for CLOSE_ON_FAILURE did expose the reasonfor the bug:

io.netty.handler.codec.EncoderException: java.lang.IllegalStateException: unexpected message type: DefaultHttpResponse, state: 1

We ought to use DefaultFullHttpResponse instead of DefaultHttpResponse.
Also keep the CLOSE_ON_FAILURE to make this more robust for future bugs.

Fixes #5720

Fix http input keep-alive handling
We were only responding to the first request on an http keep-alive connection
with a 202.
Any following requests would not be answered, leading to a timeout in the client.

Configuring a ChannelFuture for CLOSE_ON_FAILURE did expose the reason
for the bug:

`io.netty.handler.codec.EncoderException:
java.lang.IllegalStateException: unexpected message type:
DefaultHttpResponse, state: 1`

We ought to use `DefaultFullHttpResponse` instead of `DefaultHttpResponse`.
Also keep the `CLOSE_ON_FAILURE` to make this more robust for future bugs.

Fixes #5720

@mpfz0r mpfz0r added this to the 3.0.1 milestone Feb 27, 2019

@dennisoelkers dennisoelkers merged commit 9f34e09 into master Mar 13, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3397 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3207 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@dennisoelkers dennisoelkers deleted the issue-5720 branch Mar 13, 2019

mpfz0r added a commit that referenced this pull request Mar 13, 2019

Fix http input keep-alive handling (#5728)
We were only responding to the first request on an http keep-alive connection
with a 202.
Any following requests would not be answered, leading to a timeout in the client.

Configuring a ChannelFuture for CLOSE_ON_FAILURE did expose the reason
for the bug:

`io.netty.handler.codec.EncoderException:
java.lang.IllegalStateException: unexpected message type:
DefaultHttpResponse, state: 1`

We ought to use `DefaultFullHttpResponse` instead of `DefaultHttpResponse`.
Also keep the `CLOSE_ON_FAILURE` to make this more robust for future bugs.

Fixes #5720

(cherry picked from commit 9f34e09)

dennisoelkers added a commit that referenced this pull request Mar 13, 2019

Fix http input keep-alive handling (#5728) (#5769)
We were only responding to the first request on an http keep-alive connection
with a 202.
Any following requests would not be answered, leading to a timeout in the client.

Configuring a ChannelFuture for CLOSE_ON_FAILURE did expose the reason
for the bug:

`io.netty.handler.codec.EncoderException:
java.lang.IllegalStateException: unexpected message type:
DefaultHttpResponse, state: 1`

We ought to use `DefaultFullHttpResponse` instead of `DefaultHttpResponse`.
Also keep the `CLOSE_ON_FAILURE` to make this more robust for future bugs.

Fixes #5720

(cherry picked from commit 9f34e09)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.