Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of wildcards in query parser #5730

Merged
merged 2 commits into from Mar 13, 2019

Conversation

@edmundoa
Copy link
Member

commented Feb 27, 2019

Until now our custom Lucene query parser used for search auto-completion did not support wildcards. This caused the parser to throw exceptions in the background, which in 3.0 could cause the "something went wrong" page to come out, as described in #5719.

This PR adds support for wildcards in the query parser, and also modifies the code throwing the exception, ensuring that no error is thrown if a similar situation occurs.

Fixes #5719

edmundoa added 2 commits Feb 27, 2019
Improve handling of wildcards in query parser
Make parser be able to handle wildcards in terms and also pure
wildcards.

Fixes #5719
Do not throw error for undefined value in syncTo
Set default value for function argument, avoiding the query parser to
throw an error when that occurs.

@dennisoelkers dennisoelkers merged commit c571e7a into master Mar 13, 2019

3 of 4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3451 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3360 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@dennisoelkers dennisoelkers deleted the issue-5719 branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.