Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AdjustDashboardPosition Migration #5751

Merged
merged 4 commits into from Mar 12, 2019

Conversation

@kmerz
Copy link
Member

commented Mar 6, 2019

Description

Prior to this change, the migration expected that all postions
have a "width", "heigth", "row" and "col" field.
Some users did not have a "width" or "height" field.

This change will add default values for the fields in the
getPositions functions of DashboardImpl.

Also fix some warnings.

Fixes #5737

How Has This Been Tested?

  • Created a dashboard in 2.5 and removed the "width" and "height" from the position
  • Upgraded to 3.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kmerz kmerz added this to the 3.0.1 milestone Mar 6, 2019

@kmerz kmerz requested review from dennisoelkers, edmundoa and bernd Mar 6, 2019

Fix AdjustDasbboardPostion Migration
Prior to this change, the migration expected that all postions
have a "width", "heigth", "row" and "col" field.
Some users did not have a "width" or "height" field.

This change will add default values for the fields in the
getPositions functions of DashboardImpl.

Also fix some warnings.

Fixes #5737

@kmerz kmerz force-pushed the issue-5737 branch from 294ce53 to 40768a8 Mar 6, 2019

@dennisoelkers dennisoelkers changed the title Fix AdjustDasbboardPostion Migration Fix AdjustDashboardPosition Migration Mar 6, 2019

kmerz added 3 commits Mar 7, 2019
Add more dashboards to the test
Also: Fix annotations made by @dennisoelkers

@kmerz kmerz requested a review from dennisoelkers Mar 7, 2019

@dennisoelkers dennisoelkers merged commit 5dcb509 into master Mar 12, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3447 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3322 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@dennisoelkers dennisoelkers deleted the issue-5737 branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.