Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AdjustDashboardPosition Migration #5763

Merged
merged 4 commits into from Mar 12, 2019
Merged

Fix AdjustDashboardPosition Migration #5763

merged 4 commits into from Mar 12, 2019

Conversation

@kmerz
Copy link
Member

@kmerz kmerz commented Mar 12, 2019

Description

Prior to this change, the migration expected that all postions
have a "width", "heigth", "row" and "col" field.
Some users did not have a "width" or "height" field.

This change will add default values for the fields in the
getPositions functions of DashboardImpl.

Also fix some warnings.

Fixes #5737

How Has This Been Tested?

  • Created a dashboard in 2.5 and removed the "width" and "height" from the position
  • Upgraded to 3.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
kmerz added 4 commits Mar 12, 2019
Prior to this change, the migration expected that all postions
have a "width", "heigth", "row" and "col" field.
Some users did not have a "width" or "height" field.

This change will add default values for the fields in the
getPositions functions of DashboardImpl.

Also fix some warnings.

Fixes #5737
Also: Fix annotations made by @dennisoelkers
@dennisoelkers dennisoelkers merged commit 714fb66 into 3.0 Mar 12, 2019
4 checks passed
@dennisoelkers dennisoelkers deleted the issue-5737-3.0 branch Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants