Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of wildcards in query parser (3.0) #5766

Merged
merged 2 commits into from Mar 14, 2019
Merged

Add support of wildcards in query parser (3.0) #5766

merged 2 commits into from Mar 14, 2019

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Mar 13, 2019

Until now our custom Lucene query parser used for search auto-completion did not support wildcards. This caused the parser to throw exceptions in the background, which in 3.0 could cause the "something went wrong" page to come out, as described in #5719.

This PR adds support for wildcards in the query parser, and also modifies the code throwing the exception, ensuring that no error is thrown if a similar situation occurs.

Fixes #5719

edmundoa added 2 commits Mar 13, 2019
Make parser be able to handle wildcards in terms and also pure
wildcards.

Fixes #5719
Set default value for function argument, avoiding the query parser to
throw an error when that occurs.
@dennisoelkers dennisoelkers added this to the 3.0.1 milestone Mar 13, 2019
@dennisoelkers dennisoelkers requested review from edmundoa and kmerz Mar 13, 2019
kmerz
kmerz approved these changes Mar 14, 2019
@kmerz kmerz merged commit b4f5e8b into 3.0 Mar 14, 2019
3 of 4 checks passed
@kmerz kmerz deleted the issue-5719-3.0 branch Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants