Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to a repackaged and fixed version of java-grok #5800

Merged
merged 4 commits into from Mar 26, 2019

Conversation

Projects
None yet
2 participants
@bernd
Copy link
Member

bernd commented Mar 25, 2019

To support underscores ("_") in Grok match group names, we had to modify
the java-grok library to use the old regexp engine again.

See: graylog-labs/java-grok#2

This also adds a test for the Grok extractor to make sure that using
underscores works.

Fixes #5704
Fixes #5563

Switch back to a repackaged and fixed version of java-grok
To support underscores ("_") in Grok match group names, we had to modify
the java-grok library to use the old regexp engine again.

See: graylog-labs/java-grok#2

This also adds a test for the Grok extractor to make sure that using
underscores works.

Fixes #5704
Fixes #5563

@bernd bernd added this to the 3.1.0 milestone Mar 25, 2019

@bernd bernd requested a review from kmerz Mar 25, 2019

@bernd bernd removed the ready-for-review label Mar 26, 2019

@bernd

This comment has been minimized.

Copy link
Member Author

bernd commented Mar 26, 2019

I will add a test for GrokPatternService.extractPatternNames().

bernd and others added some commits Mar 26, 2019

Add test for named group with underscore
Prior to this change, there was no test for named groups
with underscores in the FunctionSnippetsTest

This change enhances the grok() test to run with a
named group with underscore.
@kmerz

kmerz approved these changes Mar 26, 2019

Copy link
Member

kmerz left a comment

LGTM 👍 Works 🎉

@kmerz kmerz merged commit e642a41 into master Mar 26, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3488 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3528 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kmerz kmerz deleted the issue-5704 branch Mar 26, 2019

bernd added a commit that referenced this pull request Mar 26, 2019

Switch back to a repackaged and fixed version of java-grok (#5800)
* Switch back to a repackaged and fixed version of java-grok

To support underscores ("_") in Grok match group names, we had to modify
the java-grok library to use the old regexp engine again.

See: graylog-labs/java-grok#2

This also adds a test for the Grok extractor to make sure that using
underscores works.

Fixes #5704
Fixes #5563

* Fix GrokPatternService#extractPatternNames and add a test for it

* Add missing license header to GrokPatternServiceTest

* Add test for named group with underscore

Prior to this change, there was no test for named groups
with underscores in the FunctionSnippetsTest

This change enhances the grok() test to run with a
named group with underscore.

(cherry picked from commit e642a41)

kmerz added a commit that referenced this pull request Mar 26, 2019

Switch back to a repackaged and fixed version of java-grok (#5800) (#…
…5807)

* Switch back to a repackaged and fixed version of java-grok

To support underscores ("_") in Grok match group names, we had to modify
the java-grok library to use the old regexp engine again.

See: graylog-labs/java-grok#2

This also adds a test for the Grok extractor to make sure that using
underscores works.

Fixes #5704
Fixes #5563

* Fix GrokPatternService#extractPatternNames and add a test for it

* Add missing license header to GrokPatternServiceTest

* Add test for named group with underscore

Prior to this change, there was no test for named groups
with underscores in the FunctionSnippetsTest

This change enhances the grok() test to run with a
named group with underscore.

(cherry picked from commit e642a41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.