Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kafka group.id to be configured #5867

Merged
merged 1 commit into from Apr 17, 2019

Conversation

@pdepaepe
Copy link
Contributor

commented Apr 12, 2019

Signed-off-by: Pierre De Paepe pierre.de-paepe@corp.ovh.com

Description

This little patch will allow graylog administrators to define a custom Kafka group_id in related input panel.
To avoid update issue, current group "graylog2" remains the default value.

Motivation and Context

If you have a big Kafka cluster with multiple graylog clusters subscribed on, each time a unhealthy consumer flaps, the rebalancing order is sent to all graylog nodes introducing unecessary stress on log ingestion.
An easy way to avoid it, consists to define for each graylog cluster a specific consumer group name.

How Has This Been Tested?

In production : ~20 graylog clusters for one kafka.

Screenshots (if appropriate):

group id

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Allow kafka group.id to be configured
Signed-off-by: Pierre De Paepe <pierre.de-paepe@corp.ovh.com>

@florianvolle florianvolle requested a review from bernd Apr 15, 2019

@bernd

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@pdepaepe Thank you for opening the new PR! I will review this in the next days.

@bernd bernd added the feature label Apr 15, 2019

@bernd
bernd approved these changes Apr 17, 2019

@bernd bernd merged commit dd5c025 into Graylog2:master Apr 17, 2019

3 of 4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3535 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3705 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@bernd

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Refs #3976

@bernd

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

@pdepaepe Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.