Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to global output list on stream output page. #5953

Merged
merged 1 commit into from May 24, 2019

Conversation

@dennisoelkers
Copy link
Member

commented May 21, 2019

Description

Motivation and Context

This change is fixing the address of the link to the global output list
on the stream output page. Before this change, it was a string literal
left over from the migration from play to react years ago.

Additionally, linter hints in that component were fixed.

Fixes #5952.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Fix link to global output list on stream output page.
This change is fixing the address of the link to the global output list
on the stream output page. Before this change, it was a string literal
left over from the migration from play to react years ago.

Additionally, linter hints in that component were fixed.

Fixes #5952.

@dennisoelkers dennisoelkers added this to the 3.1.0 milestone May 21, 2019

@dennisoelkers dennisoelkers requested review from edmundoa and mehrenreich May 21, 2019

@edmundoa edmundoa merged commit 4169d5c into master May 24, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3586 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 3928 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@edmundoa edmundoa deleted the fixing-link-on-output-page branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.