Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Set default value for email sender to empty value #5981
The previous default (
In our use case users often forgot to empty the value and left the
With this change the default is empty and if I understand the code
How Has This Been Tested?
Fired up a test instance and took a look at the empty field value.
Screenshots (if appropriate):
Sorry, did not take any :(
Types of changes
Thank you for creating this PR and for your patience while we looked into this!
Here is a bit of information while I test your PR: We are working on a new alerting system, including new notifications, that will be released in Graylog 3.1. Since this change should also be done there, I created #6159 to be sure we don't forget. Feel free to add any missing information in case I missed something.
edmundoa left a comment
As you mentioned, an empty
Thinking about it, I think this is still better than the old behaviour, where the server set this example email address as sender and this all failed anyway.