Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Multiple Navigation Concerns #6001

Merged
merged 5 commits into from Jun 11, 2019

Conversation

@kyleknighted
Copy link
Contributor

commented Jun 6, 2019

Description

  • This removes the Help and User Name text from the navigation bar and uses an icon in their place.
  • It also reduces the length of In N / Out N msg/s messages by creating a smaller experience for the same data.
  • Breaks into collapsed "hamburger" style menu at earlier breakpoint (991px)

Motivation and Context

Closes #5851

How Has This Been Tested?

Tested in all latest browsers Chrome, Firefox, Safari, and MS Edge

Screenshots (if appropriate):

image
image
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kyleknighted kyleknighted changed the title Reduce right side of nav to icons Fixing Multiple Navigation Concerns Jun 7, 2019

@kyleknighted kyleknighted added improvement and removed in progress labels Jun 7, 2019

@kyleknighted kyleknighted requested review from dennisoelkers, edmundoa and kmerz Jun 7, 2019

@kmerz
kmerz approved these changes Jun 11, 2019
Copy link
Member

left a comment

LGTM 👍

@kmerz kmerz merged commit 2c3383a into master Jun 11, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3677 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 4161 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kmerz kmerz deleted the issues-5851-2 branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.