Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nested maps in list for Content Packs #6003

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@kmerz
Copy link
Member

commented Jun 7, 2019

Description

Prior this change we missed support of maps in list of
a ReferenceMap. This is needed to support configurations
(like DashboardWidget) which can contain a list of maps.
(e.g series when two charts are merged into one)

This change will call toReferenceMap for every list item
which is a map.

Fixes #5742

Needs backport to 3.0.3

How Has This Been Tested?

  1. create a dashboard containing a merged stack chart
  2. create a content pack containing this dashboard
  3. install this content pack and change to the dashboard
  4. see that the dashboard widget with the merged chart loads as expected

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Add support for nesed maps in list for Content Packs
Prior this change we missed support of maps in list of
a ReferenceMap. This is needed to support configurations
(like DashboardWidget) which can contain a list of maps.
(e.g series when two charts are merged into one)

This change will call toReferenceMap for every list item
which is a map.

Fixes #5742

@kmerz kmerz added this to the 3.1.0 milestone Jun 7, 2019

@kmerz kmerz requested a review from bernd Jun 7, 2019

@dennisoelkers dennisoelkers changed the title Add support for nesed maps in list for Content Packs Add support for nested maps in list for Content Packs Jun 7, 2019

@bernd
bernd approved these changes Jul 1, 2019

@bernd bernd self-assigned this Jul 1, 2019

@bernd bernd merged commit a661710 into master Jul 1, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3673 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 4152 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the support-nesedt-obejects-in-ref-map branch Jul 1, 2019

bernd added a commit that referenced this pull request Jul 1, 2019
Add support for nesed maps in list for Content Packs (#6003)
Prior this change we missed support of maps in list of
a ReferenceMap. This is needed to support configurations
(like DashboardWidget) which can contain a list of maps.
(e.g series when two charts are merged into one)

This change will call toReferenceMap for every list item
which is a map.

Fixes #5742

(cherry picked from commit a661710)
kmerz added a commit that referenced this pull request Jul 2, 2019
Add support for nesed maps in list for Content Packs (#6003) (#6062)
Prior this change we missed support of maps in list of
a ReferenceMap. This is needed to support configurations
(like DashboardWidget) which can contain a list of maps.
(e.g series when two charts are merged into one)

This change will call toReferenceMap for every list item
which is a map.

Fixes #5742

(cherry picked from commit a661710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.