Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix plugin navigation item path with app prefix. #6150

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@dennisoelkers
Copy link
Member

commented Jul 17, 2019

Description

Motivation and Context

Due to the introduction of #5703, routes in the navigation bar are not
prefixed anymore automatically. Unfortunately this is required for
navigation items coming from plugins, as they have no knowledge about
the configured app path prefix.

This change is now automatically prefixing navigation items coming from
plugins.

Fixes #6149.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Prefix plugin navigation item path with app prefix.
Due to the introduction of #5703, routes in the navigation bar are not
prefixed anymore automatically. Unfortunately this is required for
navigation items coming from plugins, as they have no knowledge about
the configured app path prefix.

This change is now automatically prefixing navigation items coming from
plugins.

Fixes #6149.

@dennisoelkers dennisoelkers requested a review from mariussturm Jul 17, 2019

@dennisoelkers dennisoelkers added this to the 3.1.0 milestone Jul 17, 2019

@mariussturm mariussturm merged commit 63576ec into master Jul 17, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3923 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 4746 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@mariussturm mariussturm deleted the issue-6149 branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.