Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give visual feedback on disabled inputs #6257

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@edmundoa
Copy link
Member

commented Aug 7, 2019

This change darkens disabled inputs, making it easier to see when an input is disabled.

Before:
Screenshot 2019-08-07 at 14 08 05

After:
Screenshot 2019-08-07 at 14 32 36

Refs #6155

Give visual feedback on disabled inputs
This change darkens disabled inputs, making it easier to see when an
input is disabled.

@edmundoa edmundoa added this to the 3.1.0 milestone Aug 7, 2019

@kyleknighted

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

Changes LGTM but haven’t test driven the PR

@dennisoelkers
Copy link
Member

left a comment

Good improvement!

@dennisoelkers dennisoelkers merged commit 2f54511 into master Aug 7, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 4071 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 5091 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@dennisoelkers dennisoelkers deleted the disabled-inputs-feedback branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.