Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global API browser link #6826

Merged
merged 2 commits into from Nov 22, 2019
Merged

Fix global API browser link #6826

merged 2 commits into from Nov 22, 2019

Conversation

@mpfz0r
Copy link
Member

mpfz0r commented Nov 19, 2019

Using Routes, will run 'qualifyUrl()' twice.

@jalogisch

This comment has been minimized.

Copy link
Member

jalogisch commented Nov 20, 2019

I guess this FIX: #6823 ?

Using Routes, will run 'qualifyUrl()' twice if a path is used on the
reverse proxy.

Fixes #6823
@mpfz0r mpfz0r requested a review from dennisoelkers Nov 20, 2019
@mpfz0r mpfz0r added ready-for-review and removed in progress labels Nov 20, 2019
@mpfz0r mpfz0r added this to the 3.1.4 milestone Nov 20, 2019
Copy link
Member

dennisoelkers left a comment

Looks good, works, but two remarks:

1.) Could you please remove the (now) unused constant from the Routes object?
2.) We have a convention to fix linter hints when we touch files. There are three hints in here, which are simple to fix. Could you please address these?

graylog2-web-interface/src/pages/NodesPage.jsx Outdated Show resolved Hide resolved
@mpfz0r mpfz0r force-pushed the issue-6823 branch from 57ac273 to e1cb456 Nov 21, 2019
@mpfz0r mpfz0r requested a review from dennisoelkers Nov 21, 2019
Copy link
Member

dennisoelkers left a comment

LGTM, works! Due to the scope of the fix, the remaining linter hint is okay.

@dennisoelkers dennisoelkers merged commit 9d571ce into master Nov 22, 2019
3 of 4 checks passed
3 of 4 checks passed
ci-web-linter Jenkins build graylog-pr-linter-check 5163 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 6861 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@dennisoelkers dennisoelkers deleted the issue-6823 branch Nov 22, 2019
mpfz0r added a commit that referenced this pull request Nov 22, 2019
* Fix global API browser link

Using Routes, will run 'qualifyUrl()' twice if a path is used on the
reverse proxy.

Fixes #6823

* Fix review comments

(cherry picked from commit 9d571ce)
dennisoelkers added a commit that referenced this pull request Nov 22, 2019
* Fix global API browser link

Using Routes, will run 'qualifyUrl()' twice if a path is used on the
reverse proxy.

Fixes #6823

* Fix review comments

(cherry picked from commit 9d571ce)
linuspahl added a commit that referenced this pull request Nov 27, 2019
* Fix global API browser link

Using Routes, will run 'qualifyUrl()' twice if a path is used on the
reverse proxy.

Fixes #6823

* Fix review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.