Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields of all SD-ELEMENTS, not just the first. #744

Merged
merged 6 commits into from Oct 30, 2014
Merged

Conversation

@bernd
Copy link
Member

@bernd bernd commented Oct 21, 2014

Before this only the fields of the first RFC5424 SD-ELEMENT have been
added to the fields map. This is fixed now by iterating over all
existing SD-ELEMENTS returned by the syslog parser.

Known problem:

If two different SD-ELEMENTs share the same key in the SD-PARAMS, they
overwrite each other. See code comments for details.

@bernd bernd self-assigned this Oct 21, 2014
@bernd bernd added the bug label Oct 21, 2014
@bernd bernd added this to the 0.92 milestone Oct 21, 2014
Before this only the fields of the first RFC5424 SD-ELEMENT have been
added to the fields map. This is fixed now by iterating over all
existing SD-ELEMENTS returned by the syslog parser.

Known problem:

If two different SD-ELEMENTs share the same key in the SD-PARAMS, they
overwrite each other. See code comments for details.
@bernd bernd force-pushed the syslog-multi-sd-elements branch from 9083773 to 352bbce Oct 22, 2014
Jochen Schalanda added 2 commits Oct 28, 2014
Activating "expand_structured_data" will now prefix the extracted attributes
from structured syslog messages with the SD-ID of the SD-ELEMENT they've been
extracted from, e. g. '[meta key="val"][mySD@12345 key="val"]' would result in
two attributes "meta_key=val" and "mySD@12345_key=val" in the final GELF message.
@joschi joschi force-pushed the syslog-multi-sd-elements branch from 2b5c454 to 0dba8b7 Oct 28, 2014
bernd added a commit that referenced this pull request Oct 30, 2014
Add fields of all SD-ELEMENTS, not just the first.
@bernd bernd merged commit 328ab7f into master Oct 30, 2014
1 check was pending
1 check was pending
@joschi
continuous-integration/travis-ci The Travis CI build is in progress
Details
@bernd bernd deleted the syslog-multi-sd-elements branch Oct 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant