Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling for search errors #954

Merged
merged 3 commits into from Feb 9, 2015
Merged

Fix error handling for search errors #954

merged 3 commits into from Feb 9, 2015

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Feb 6, 2015

This change set improves the information given in case of search errors and unifies the error handling.

This will fix #947.

Jochen Schalanda added 3 commits Feb 6, 2015
Jochen Schalanda
For some use cases getting the actual response body of a failed request (i. e. with
response codes in the 4xx or 5xx range) might be useful.
@joschi joschi added this to the 1.0.0 milestone Feb 6, 2015
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Feb 9, 2015

I was taking a look into this and I didn't see any obvious mistake. Also testing it together with graylog-labs/graylog2-web-interface#1108 fixes the issue and seems to work even with wrong or complex queries, so feel free to merge :shipit:

joschi added a commit that referenced this pull request Feb 9, 2015
Fix error handling for search errors
@joschi joschi merged commit 7c3ec85 into 1.0 Feb 9, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@joschi joschi deleted the 947-parse-errors branch Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.