Fix error handling for search errors #954
Merged
Conversation
3 commits
Feb 6, 2015
added For some use cases getting the actual response body of a failed request (i. e. with response codes in the 4xx or 5xx range) might be useful.
I was taking a look into this and I didn't see any obvious mistake. Also testing it together with graylog-labs/graylog2-web-interface#1108 fixes the issue and seems to work even with wrong or complex queries, so feel free to merge |
joschi
added a commit
that referenced
this pull request
Feb 9, 2015
Fix error handling for search errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This change set improves the information given in case of search errors and unifies the error handling.
This will fix #947.