New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically update dashboard widgets with keyword range #956

Merged
merged 1 commit into from Feb 10, 2015

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Feb 9, 2015

This change set enables KeywordRange to update the start and end timestamps of the time range dynamically.

Fixes graylog-labs/graylog2-web-interface#958

@joschi joschi added this to the 1.0.0 milestone Feb 9, 2015

@joschi joschi added the papercut label Feb 9, 2015

timeRange = new AbsoluteRange(from, to);
} else {
throw new InvalidRangeParametersException("range_type not recognized");
switch (rangeType) {

This comment has been minimized.

@kroepke

This comment has been minimized.

@joschi

joschi Feb 10, 2015

Contributor

As a lazy-ass developer I like the IntelliJ IDEA automatic refactorings…
Yaaaaawn

@kroepke

This comment has been minimized.

Member

kroepke commented Feb 10, 2015

lgtm, please merge!

@kroepke kroepke self-assigned this Feb 10, 2015

joschi added a commit that referenced this pull request Feb 10, 2015

Merge pull request #956 from Graylog2/958-dynamic-keyword-range
Dynamically update dashboard widgets with keyword range

@joschi joschi merged commit 54d15bc into 1.0 Feb 10, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@joschi joschi deleted the 958-dynamic-keyword-range branch Feb 10, 2015

@joschi joschi restored the 958-dynamic-keyword-range branch Feb 10, 2015

@joschi joschi deleted the 958-dynamic-keyword-range branch Feb 10, 2015

joschi added a commit that referenced this pull request Jul 17, 2015

Fix dynamic keyword time-ranges for dashboard widgets from content packs
Keyword time-ranges are static by default but should be dynamic for dashboard widgets
created from content packs.

Refs #956
Fixes graylog-labs/graylog2-web-interface#1533

joschi added a commit that referenced this pull request Jul 17, 2015

Make KeywordRange dynamically evaluate the keyword by default
The static behaviour has been removed completely to prevent accidental usage.

Refs #956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment