This repository has been archived by the owner on Jan 8, 2019. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename some members of the store to clarify what they do.
- Clear form after dashboard creation. - Only use jQuery to update title and description if they are present on the DOM.
const EditDashboardModalTrigger = require('./EditDashboardModalTrigger'); | ||
const PermissionsMixin = require('../../util/PermissionsMixin'); | ||
|
||
const DashboardStore = require('../../stores/dashboard/DashboardStore'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please use module imports? That way imports are theoretically independent of the module loader user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, will change that 👍
All issues should be addressed with the latest changes 😄 |
Thank you for reviewing @dennisoelkers! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of the dashboard list page to React. I had to do some yak-shaving in the
DashboardStore
, as we need to expose the list of editable dashboards in other components.