New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defensive coding in atom link #70

Merged
merged 2 commits into from May 21, 2014

Conversation

Projects
None yet
2 participants
@ploeh
Contributor

ploeh commented May 20, 2014

The purpose of this PR is mainly to be able to better to troubleshoot #69 by adding some more explicit exception messages.

@sgryt

This comment has been minimized.

Show comment
Hide comment
@sgryt

sgryt May 21, 2014

Contributor

Maybe include the value of the href attribute in the exception message when the rel attribute is missing, to further aid the diagnostics?
And perhaps include the rel value (if present) in the exception message, when the href is missing?

Contributor

sgryt commented May 21, 2014

Maybe include the value of the href attribute in the exception message when the rel attribute is missing, to further aid the diagnostics?
And perhaps include the rel value (if present) in the exception message, when the href is missing?

@sgryt sgryt merged commit fd6d7e3 into master May 21, 2014

@sgryt sgryt deleted the defensive-coding-in-atom-link branch May 21, 2014

@ploeh

This comment has been minimized.

Show comment
Hide comment
@ploeh

ploeh May 21, 2014

Contributor

That may be an idea, but on the other hand, that might introduce additional complexity, because that would mean that the code would also have to check for null for the other value...

Let's see if this is enough to troubleshoot, of if more diagnostics are required...

Contributor

ploeh commented May 21, 2014

That may be an idea, but on the other hand, that might introduce additional complexity, because that would mean that the code would also have to check for null for the other value...

Let's see if this is enough to troubleshoot, of if more diagnostics are required...

@sgryt

This comment has been minimized.

Show comment
Hide comment
@sgryt

sgryt May 21, 2014

Contributor

I know, but IME, you never can get too much information when troubleshooting that kind of failure :)

Contributor

sgryt commented May 21, 2014

I know, but IME, you never can get too much information when troubleshooting that kind of failure :)

@ploeh

This comment has been minimized.

Show comment
Hide comment
@ploeh

ploeh May 21, 2014

Contributor

I hear you :)

Contributor

ploeh commented May 21, 2014

I hear you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment