Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change entry point to webpack output #27

Merged
merged 5 commits into from
Nov 27, 2021

Conversation

QuaidBartolomei
Copy link
Contributor

fixes #23

The package.json now points to webpack output folder. Use the new pre-publish script to build for production. Dependant modules will need to update their import lines (see readme for example)

@QuaidBartolomei
Copy link
Contributor Author

This worked when I imported the package locally but it did not work when I merged it into my repo fork and tried installing the module from github like the treetracker-web-map-client is currently doing. I'll have to spend some more time testing this setup.

@QuaidBartolomei QuaidBartolomei marked this pull request as ready for review November 25, 2021 01:34
name: "greenstand",
type: "var"
},
library: { name: 'greenstand', type: 'umd' },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, I always get confused by the import/export stuff, like umd, comm...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't totally understand the differences either, I just kept looking at examples and trying different things. I can say at least that changing umd back to var will break it. I'm not sure if umd is the best choice but it's probably fine.

@dadiorchen dadiorchen merged commit 4b4ccd6 into Greenstand:main Nov 27, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release web map core as a NPM module
2 participants