-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change entry point to webpack output #27
Conversation
This worked when I imported the package locally but it did not work when I merged it into my repo fork and tried installing the module from github like the |
name: "greenstand", | ||
type: "var" | ||
}, | ||
library: { name: 'greenstand', type: 'umd' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, I always get confused by the import/export stuff, like umd, comm...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't totally understand the differences either, I just kept looking at examples and trying different things. I can say at least that changing umd
back to var
will break it. I'm not sure if umd
is the best choice but it's probably fine.
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fixes #23
The package.json now points to webpack output folder. Use the new
pre-publish
script to build for production. Dependant modules will need to update their import lines (see readme for example)