Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter to return content #1

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@michaelkl
Copy link

@michaelkl michaelkl commented Mar 11, 2017

Hi!
First of all, thank you for your filter rework!

I'm using Ruby 2.3.3 and nanoc 4.6.2. I've got problems running your filter.

Looking on my nanoc's built-in filters I found out that filter's run method should return content. So here's the patch.

@GregOnNet
Copy link
Owner

@GregOnNet GregOnNet commented Mar 27, 2019

Hi @michaelkl,

I am so sorry. I did not see your PR until now. 😓
Do you still have a need that I merge your PR? 😇

@michaelkl
Copy link
Author

@michaelkl michaelkl commented Mar 27, 2019

Hi @GregOnNet,

Honestly, I haven't been using it for a long time. :-)

But as I remember, it was not working for me at all (and it seemed strange). I guess it is still a good idea to make it work finally, and later is better than never.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.