diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ecc235e..6b72547 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -47,6 +47,7 @@ jobs: symfony: '5.4.*' coverage: true bootable: true + quality: true fail-fast: false steps: - name: Checkout @@ -82,9 +83,9 @@ jobs: run: composer update --no-progress --ansi --prefer-stable ${{ matrix.dependency }} - name: Bundle is bootable - if: ${{ matrix.bootable && github.event_name == 'push' }} + if: matrix.bootable && github.event_name == 'push' env: - SKELETON_VERSION: ${{matrix.symfony}} + SKELETON_VERSION: ${{ matrix.symfony }} run: | composer create-project "symfony/skeleton:${SKELETON_VERSION}" flex cd flex @@ -92,16 +93,13 @@ jobs: composer req gheb/docusign-bundle:dev-${GITHUB_REF#refs/heads/} - name: Run php-cs-fixer tests + if: matrix.quality run: php-cs-fixer fix --diff --dry-run - name: Run phpstan tests - if: matrix.dependency == '' && matrix.php == '7.4' + if: matrix.quality run: vendor/bin/phpstan analyze - - name: Run phpstan tests lowest - if: matrix.dependency != '' && matrix.php == '7.4' - run: vendor/bin/phpstan analyze -c phpstan.neon.lowest.dist - - name: Prepare PHPUnit tests env: DOCUSIGN_RSA_PASSPHRASE: ${{ secrets.DOCUSIGN_RSA_PASSPHRASE }} diff --git a/phpstan.neon.lowest.dist b/phpstan.neon.lowest.dist deleted file mode 100644 index 566faa8..0000000 --- a/phpstan.neon.lowest.dist +++ /dev/null @@ -1,19 +0,0 @@ -parameters: - level: 5 - paths: - - src - inferPrivatePropertyTypeFromConstructor: true - excludePaths: - # bc flysystem - - src/Filesystem/FilesystemInterface.php - - src/Filesystem/FilesystemDecorator.php - - src/Filesystem/AbstractFilesystemDecorator.php - ignoreErrors: - - '#Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition::useAttributeAsKey\(\)\.#' - - # known bug of phpstan - - "#Call to static method file\\(\\) on an unknown class Lcobucci\\\\JWT\\\\Signer\\\\Key\\\\InMemory\\.#" - - "#Call to static method forSymmetricSigner\\(\\) on an unknown class Lcobucci\\\\JWT\\\\Configuration\\.#" - - # flysystem compat layer - - "#Class League\\\\Flysystem\\\\UnixVisibility\\\\PortableVisibilityConverter not found\\.#"