Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sf 4.0 support #180

Merged
merged 2 commits into from Dec 28, 2017

Conversation

Projects
None yet
3 participants
@andreybolonin
Copy link
Contributor

andreybolonin commented Nov 27, 2017

No description provided.

@linaori

This comment has been minimized.

Copy link

linaori commented Dec 12, 2017

When adding 4.0 support, don't forget to make the services public, as they will fail in 4.0 due to being private. Example:

PHP Deprecated: The "gregwar_captcha.generator" service is private, getting it from the
container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make 
the service public, or stop using the container directly and use dependency injection 
instead.
@Gregwar

This comment has been minimized.

Copy link
Owner

Gregwar commented Dec 12, 2017

@iltar is adding the public keyword a bc break? (like would it be unknown on older versions)

@linaori

This comment has been minimized.

Copy link

linaori commented Dec 12, 2017

@Gregwar public: true is probably already present since 2.0 or 2.1 so that won't be an issue. The issue with 4.0 will be that all services are private by default, instead of public.

@andreybolonin

This comment has been minimized.

Copy link
Contributor Author

andreybolonin commented Dec 28, 2017

@iltar @Gregwar
public: true done

@Gregwar Gregwar merged commit 6394303 into Gregwar:master Dec 28, 2017

@Gregwar

This comment has been minimized.

Copy link
Owner

Gregwar commented Dec 28, 2017

Ok
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.