Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add copy clause sqlness tests #1198

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 17, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your

Add copy clause sqlness tests

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#1081

@WenyXu WenyXu marked this pull request as ready for review March 17, 2023 08:48
@WenyXu WenyXu force-pushed the test/add-copy-clause-sqlness-tests branch from 33bec30 to 8db4280 Compare March 17, 2023 08:53
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1198 (8db4280) into develop (09491d6) will decrease coverage by 0.55%.
The diff coverage is n/a.

❗ Current head 8db4280 differs from pull request most recent head 2d68f0a. Consider uploading reports for the commit 2d68f0a to get more accurate results

@@             Coverage Diff             @@
##           develop    #1198      +/-   ##
===========================================
- Coverage    85.19%   84.64%   -0.55%     
===========================================
  Files          485      485              
  Lines        72017    72017              
===========================================
- Hits         61355    60961     -394     
- Misses       10662    11056     +394     

@WenyXu WenyXu force-pushed the test/add-copy-clause-sqlness-tests branch from 8db4280 to 2d68f0a Compare March 21, 2023 01:38
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit b8f7f60 into GreptimeTeam:develop Mar 21, 2023
10 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants