Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refine Makefile #139

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Aug 24, 2023

  1. Add 'GO111MODULE=on CGO_ENABLED=0' to make it more portable;

  2. Add multiple make targets: 'update-modules'/'install'/'clean';

1. Add 'GO111MODULE=on CGO_ENABLED=0' to make it more portable;

2. Add multiple make targets: 'update-modules'/'install'/'clean';

Signed-off-by: zyy17 <zyylsxm@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #139 (2fb6d5d) into develop (294be69) will increase coverage by 7.43%.
Report is 3 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #139      +/-   ##
===========================================
+ Coverage    21.94%   29.38%   +7.43%     
===========================================
  Files            8        8              
  Lines          948      953       +5     
===========================================
+ Hits           208      280      +72     
+ Misses         683      608      -75     
- Partials        57       65       +8     

see 1 file with indirect coverage changes

Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawnh2 shawnh2 merged commit 297f441 into GreptimeTeam:develop Aug 24, 2023
6 checks passed
@zyy17 zyy17 deleted the chore/refine-makefile branch August 24, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants