New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified how `redirect_uri`, `client_id`, `client_secret` etc are accessed #2

Merged
merged 3 commits into from Nov 20, 2012

Conversation

Projects
None yet
2 participants
@kracekumar
Contributor

kracekumar commented Nov 20, 2012

Changes

I have made a lot of cosmetic changes.

  1. Make 2 spaces to 4 spaces in oauth.py. In python it is standard practice to use 4 spaces.
  2. Added GOOGLE_CLIENT_ID, GOOGLE_CLIENT_SECRET, REDIRECT_URI, GOOGLE_ACCOUNTS_BASE_URL, SECRET_KEY.
  3. Now user needs to pass redirect_uri, google_accounts_base_url if a user imports flask-login-oauth2, no longer library has access to app config so user should manually pass the required uri's.
  4. Modified changes with respect to PEP8.
  5. Added requirements.txt - all the external dependencies required goes into this file, so user can install required dependencies by running pip install -r requirements.txt.

I haven't tested command line options please check that.

@kracekumar

This comment has been minimized.

Contributor

kracekumar commented Nov 20, 2012

Fixes issue #1.

@ghost ghost assigned codeanu Nov 20, 2012

codeanu added a commit that referenced this pull request Nov 20, 2012

Merge pull request #2 from kracekumar/master
Modified how `redirect_uri`, `client_id`, `client_secret` etc are accessed

@codeanu codeanu merged commit 9bb7e75 into GrexIt:master Nov 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment