From e659200c911d24a7d7b1d84d86291c11f9e5b11b Mon Sep 17 00:00:00 2001 From: Javier Collado Date: Thu, 8 Aug 2019 22:06:09 +0200 Subject: [PATCH] Use environment variable, not hardcoded token --- .circleci/config.yml | 2 +- sonar-project.properties | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 6758ad28..bd6f3c87 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -93,4 +93,4 @@ jobs: export PATH=$SONAR_SCANNER_HOME/bin:$PATH export SONAR_SCANNER_OPTS="-server" - sonar-scanner + sonar-scanner -Dsonar.login=$SONAR_AUTH_TOKEN diff --git a/sonar-project.properties b/sonar-project.properties index 97295d63..fec76267 100644 --- a/sonar-project.properties +++ b/sonar-project.properties @@ -1,3 +1,6 @@ +# server +sonar.host.url=https://sonarcloud.io + # project sonar.projectKey=GreyNoise-Intelligence_pygreynoise sonar.organization=greynoise-intelligence @@ -8,7 +11,3 @@ sonar.tests=tests sonar.python.pylint.reportPath=workspace/pylint.txt sonar.python.xunit.reportPath=workspace/test_results/pytest.xml sonar.python.coverage.reportPaths=workspace/coverage/report.xml - -# authentication -sonar.host.url=https://sonarcloud.io -sonar.login=36b503aeaab2a80a95d98e7fb105772d7a0c0c0b