New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use warnings; #1

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
2 participants
@lorn

lorn commented Jan 31, 2017

Recomendation from CPANTS:

http://cpants.cpanauthors.org/dist/POE-Loop-EV

use_warnings
Add 'use warnings' (or its equivalents) to all modules (this will require
perl > 5.6), or convince us that your favorite module is well-known enough
and people can easily see the modules warn when something bad happens.

Error: POE::Loop::EV

This PR belong to my montly PR-Challenge

Add use warnings;
Recomendation from CPANTS:

http://cpants.cpanauthors.org/dist/POE-Loop-EV

```
use_warnings
Add 'use warnings' (or its equivalents) to all modules (this will require
perl > 5.6), or convince us that your favorite module is well-known enough
and people can easily see the modules warn when something bad happens.

Error: POE::Loop::EV
```

This PR belong to my montly PR-Challenge

@Grinnz Grinnz merged commit 227102d into Grinnz:master Feb 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Grinnz

This comment has been minimized.

Show comment
Hide comment
@Grinnz

Grinnz Feb 6, 2017

Owner

Thanks. Warnings were not enabled because they are not enabled in POE::Kernel, but it is a good idea to enable them here.

Owner

Grinnz commented Feb 6, 2017

Thanks. Warnings were not enabled because they are not enabled in POE::Kernel, but it is a good idea to enable them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment