Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grive does not create directory for shared folders #8

Closed
match065 opened this issue May 1, 2012 · 27 comments
Closed

Grive does not create directory for shared folders #8

match065 opened this issue May 1, 2012 · 27 comments
Assignees
Labels

Comments

@match065
Copy link
Member

match065 commented May 1, 2012

https://github.com/match065/grive/issues/7?_nid=45063736#issuecomment-5439219

@ghost ghost assigned match065 May 1, 2012
@sgbeal
Copy link

sgbeal commented May 1, 2012

i have another shared folder which does not exhibit this problem but also doesn't get synced. Unfortunately can't attach a screenshot here, but here's a temporary link:

http://wanderinghorse.net/wh/tmp/gdrive-sgbeal-201205011729.png

Notice that "counters" and "fossil-collab" are shared, but grive syncs:

$ find . -type d
.
./counters
./Docs
./Docs/Gaming
./Docs/Gaming/Fudge
./Docs/Gaming/Ideas
./Docs/Work
./Docs/Work/Consol
./Docs/Work/Consol/maxdome
./Docs/Misc

@match065
Copy link
Member Author

match065 commented May 1, 2012

I can't reproduce the problem. Can you tell me how did your create the "ScGrBa" folder?

@sgbeal
Copy link

sgbeal commented May 2, 2012

Sorry for the delay - i slept all afternoon yesterday and just got back from work.

i created all of those folders via the old GDocs web interface, with the exception of "counters" and the top-level "Docs" dir (my virtual root, which i moved all my old GDocs folders into). The "counters" dir (which gets synced at top-level) was created via the newer GDrive interface, but i don't remember if it was initially created at the (sub)dir level which it is at now. Since i'm (exclusively) on Linux, i'm not using any drive syncing which would have created the dirs for me (not counting grive, but i haven't added any dirs locally).

Unfortunately i won't have access to my "real" computer again until the weekend - my netbook is too slow to do any significant compilation on, so i'll have to wait until Friday before i can try it out again.

If you're not seeing the problem, then great. i'll give it another look on Friday or Saturday, and maybe it will have gone away on my side by then as well :).

@match065
Copy link
Member Author

match065 commented May 3, 2012

Looks like I can't re-do what you did to create the folders, cos the old GDocs web is gone.

In order to understand what is going on, I need to log the server's response text. Let me prepare some tools to do that. Note that the log may contain some sensitive information about your documents (e.g. titles, creation time etc, not the content). Please take a look yourself before sending it to me.

@sgbeal
Copy link

sgbeal commented May 4, 2012

Weird - today i pulled the latest and it's doing something different: synching my 'counters' files into ./

[stephan@hamsun:/cvs/grive/grive]$ mkdir foo
[stephan@hamsun:
/cvs/grive/grive]$ cd foo
[stephan@hamsun:~/cvs/grive/grive/foo]$ ../grive
downloading ./ship-0074.svg
downloading ./ships-counters-halfinch.svg
downloading ./Docs/Work/Consol/2012-04-XX HTML5-5 Fragen-5 Antworten_ v2.doc
downloading ./ship-0077.svg
downloading ./ship-0076.svg
...

and it's still missing a couple of the dirs in the screenshot i sent:

[stephan@hamsun:~/cvs/grive/grive/foo]$ find . -type d
.
./Docs
./Docs/Gaming
./Docs/Gaming/Fudge
./Docs/Gaming/Ideas
./Docs/Work
./Docs/Work/Consol
./Docs/Work/Consol/maxdome
./Docs/Misc

i cannot account for any weirdness in my setup. Sorry about that :(. AFAIR i haven't moved any files around since the last tests, only edited a few spreadsheets.

@match065
Copy link
Member Author

match065 commented May 5, 2012

It may be due to google internally moved some of the data. Thanks for keeping me informed. I will see what I can do.

@match065
Copy link
Member Author

match065 commented May 6, 2012

I think I know the problem. It's probably due to grive only fetch part of the data about the folders.

Can you please see if the v0.0.4 branch does the right thing? If yes, I will roll out another release.

@sgbeal
Copy link

sgbeal commented May 6, 2012

You seem to have solved it :)

[stephan@hamsun:~/cvs/grive/grive/foo]$ ../grive
downloading ./Docs/Gaming/ScGrBa/counters/ship-0074.svg
downloading ./Docs/Gaming/ScGrBa/counters/ships-counters-halfinch.svg
downloading ./Docs/Work/Consol/2012-04-XX HTML5-5 Fragen-5 Antworten_ v2.doc
...

All dirs/files look perfect when it's finished. This is great stuff :)

@match065
Copy link
Member Author

match065 commented May 6, 2012

Thank you! I am releasing v0.0.4 then.

@match065 match065 closed this as completed May 6, 2012
@sgbeal
Copy link

sgbeal commented May 6, 2012

i spoke too soon about the perfect sync, though - i found a dir which contains some pngs which were not synched.

http://www.wanderinghorse.net/wh/tmp/gdrive-sgbeal-201205061620.png

vs.

[stephan@host:~/cvs/grive/grive/foo]$ find . -type d
.
./Docs
./Docs/Gaming
./Docs/Gaming/Fudge
./Docs/Gaming/ScGrBa
./Docs/Gaming/ScGrBa/counters
./Docs/Work
./Docs/Work/Consol
./Docs/Work/Consol/maxdome
./Docs/Misc

PS: i do not generally expect (but don't care if) dirs which contain no actual files (as opposed to gdocs) to be created locally, and do not consider either behaviour a bug.

@match065 match065 reopened this May 6, 2012
@match065
Copy link
Member Author

match065 commented May 6, 2012

I will add some debugging facility to collect log files in the upcoming builds.

@ghost ghost assigned nestal and match065 May 7, 2012
@nestal
Copy link
Member

nestal commented May 9, 2012

Hi, just want to ask if the missing folder is actually shared within your own drive?

@sgbeal
Copy link

sgbeal commented May 9, 2012

Hi, nestal,

It was shared via the gdocs interface before gdrive was released. After gdrive i moved all of my top-level GDocs folders into a single top-level GDrive folder named Docs (to simplify synching to my hard drive).

@nestal
Copy link
Member

nestal commented May 9, 2012

By looking at the code I think it may cause problems if a folder has multiple parents, but it doesn't look like this is your case.

@nestal
Copy link
Member

nestal commented May 9, 2012

Hope that match's new debug code can tell us more about it.

@sgbeal
Copy link

sgbeal commented May 9, 2012

AFAIK i don't have multiple parents anywhere (i don't think the UI allows it, even if the data model does), but i have moved that folder before, so maybe there's some historical information about its parentage somewhere (e.g. in the context of versioning). i'm just guessing, though - i know nothing about the gdrive protocols and APIs.

@nestal
Copy link
Member

nestal commented May 9, 2012

Yes the UI allows it. You can press ctrl when dragging the folders in "My Drive". The same folder will appear in multiple folders.

@match065
Copy link
Member Author

can you please check again if v0.0.5 fixes this problem?

@sgbeal
Copy link

sgbeal commented May 15, 2012

This time it synced a lot of PDF files i had forgotten about :).

Everything seems to be working great (expected dir structure and files), but after syncing i found the following files which are not from me:

[stephan@host:~/cvs/grive/grive/foo]$ l *.xml
-rw-rw-r-- 1 stephan stephan 30006 May 15 08:54 dir-065432.xml
-rw-rw-r-- 1 stephan stephan 342491 May 15 08:54 first-065432.xml
-rw-rw-r-- 1 stephan stephan 365335 May 15 08:55 second-065508.xml
-rw-rw-r-- 1 stephan stephan 137848 May 15 08:55 second-065546.xml

They're full of google-related metadata, it seems. Maybe temp files left over by grive?

@match065
Copy link
Member Author

yes these are log files generated by grive. I forgot to remove the debug code that generated them before releasing 0.0.5. I will make them configurable in the next version

@sgbeal
Copy link

sgbeal commented May 21, 2012

i think this can be closed? i have shared folders (multiple levels deep with different sharing per level in some cases) being synced just fine by grive.

@match065
Copy link
Member Author

Yes if you think it's OK. It's raised by you and so it's your decision.

@sgbeal
Copy link

sgbeal commented May 24, 2012

i don't have the permissions to close this. As far as i'm concerned, syncing appears to work more or less reliably (barring the occasional network hang and similar stuff, but there's no much you can do about that).

@match065
Copy link
Member Author

It looks strange that you can't close it. Some people can close the issues raise by them.

@ramsiw ramsiw mentioned this issue May 16, 2013
@ghost ghost mentioned this issue Dec 2, 2014
@ryukinix
Copy link

ryukinix commented Oct 7, 2015

I have the same problem yet. (i think my grive is updated: grive version 0.4.0-pre Oct 6 2015 23:21:35)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants