Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Nov 1, 2013
  1. @fabpot

    bug #9332 [Config] Quoting reserved characters (WouterJ)

    fabpot authored
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    [Config] Quoting reserved characters
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    a5c0123 Use Inline class to quote reserved characters
Commits on Oct 31, 2013
  1. @WouterJ
  2. @fabpot

    minor #9244 [Console] make parent constructor test more reliable (Tob…

    fabpot authored
    …ion)
    
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    [Console] make parent constructor test more reliable
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixes   | #9186 , f2b60e9
    | Tests pass?   | yes
    | license?      | MIT
    
    It also fixes the test since f2b60e9 and improves phpdoc
    
    The second commit improves regex performance to validate name (using possesive quantifier).
    
    I did some basic performance tests http://3v4l.org/PuvuL
    The new regex only takes 1/3 of the time compared to the old one!
    
    Commits
    -------
    
    5798029 [Console] improve regex performance to validate name
    22b09ce [Console] make parent constructor test more reliable
  3. @fabpot

    bug #9423 [Form] fix CsrfProviderAdapter (Tobion)

    fabpot authored
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    [Form] fix CsrfProviderAdapter
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixes   | #9418
    | Tests pass?   | yes
    | license?      | MIT
    
    Commits
    -------
    
    887f71c [Form] fix CsrfProviderAdapter
  4. @fabpot

    minor #9424 fixes #9342 adding on-invalid="ignore" (= null on constru…

    fabpot authored
    …ctor argument) (cordoval)
    
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    fixes #9342 adding on-invalid="ignore" (= null on constructor argument)
    
    :baby:
    
    Commits
    -------
    
    d44fd2d fixes #9342 adding on-invalid="ignore" (= null on constructor argument)
  5. @cordoval
  6. @fabpot

    feature #9342 Add X-Debug-Url profiler url header (adrienbrault)

    fabpot authored
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    Add X-Debug-Url profiler url header
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | None
    
    Hey, working with rest APIs I find it way more convenient to have the profiler url directly in the header ... We human are used to deal with hypermedia!
    A little bit of hateoas in symfony :)
    
    Commits
    -------
    
    2f09754 Add X-Debug-Url profiler url header
  7. @Tobion

    [Form] fix CsrfProviderAdapter

    Tobion authored
  8. @fabpot
Commits on Oct 30, 2013
  1. @adrienbrault
  2. @fabpot

    bumped Symfony version to 2.4.0

    fabpot authored
  3. @fabpot

    updated VERSION for 2.4.0-BETA2

    fabpot authored
  4. @fabpot
  5. @fabpot

    bug #9408 [Form] Fixed failing FormDataExtractorTest (bschussek)

    fabpot authored
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    [Form] Fixed failing FormDataExtractorTest
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    4807c5e [Form] Fixed failing FormDataExtractorTest
  6. @webmozart
  7. @fabpot

    fixed CS

    fabpot authored
  8. @fabpot

    Merge branch '2.3'

    fabpot authored
    * 2.3:
      fixed CS
      fixed CS
      [HttpKernel] fixed memory limit display in MemoryDataCollector
      Fixed the error handling when decoding invalid XML to avoid a Warning
      [Form] Fixed: The "data" option is taken into account even if it is NULL
      [DomCrawler] [HttpFoundation] Make `Content-Type` attributes identification case-insensitive
    
    Conflicts:
    	src/Symfony/Bundle/FrameworkBundle/Tests/Templating/TimedPhpEngineTest.php
  9. @fabpot

    fixed CS

    fabpot authored
  10. @fabpot

    Merge branch '2.2' into 2.3

    fabpot authored
    * 2.2:
      fixed CS
      Fixed the error handling when decoding invalid XML to avoid a Warning
      [Form] Fixed: The "data" option is taken into account even if it is NULL
      [DomCrawler] [HttpFoundation] Make `Content-Type` attributes identification case-insensitive
    
    Conflicts:
    	src/Symfony/Component/Form/Extension/Core/Type/FormType.php
  11. @fabpot

    fixed CS

    fabpot authored
Commits on Oct 29, 2013
  1. @fabpot

    minor #9389 [FrameworkBundle] Update deprecation message (asm89)

    fabpot authored
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Update deprecation message
    
    Small addition to (doc string only):
    symfony#9252
    
    Commits
    -------
    
    b057fab [FrameworkBundle] Update deprecation message
  2. @fabpot

    bug #9397 [BUG][Form] Fix nonexistent key id in twig of data collecto…

    fabpot authored
    …r (francoispluchino)
    
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    [BUG][Form] Fix nonexistent key id in twig of data collector
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    When you create a single button form type, the id of data collector does not exist. It's caused by the PR #9394.
    
    Commits
    -------
    
    19c74f3 Fix nonexistent key id in twig of data collector
Commits on Oct 28, 2013
  1. @francoispluchino
  2. @fabpot

    bug #9395 [HttpKernel] fixed memory limit display in MemoryDataCollec…

    fabpot authored
    …tor (hhamon)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [HttpKernel] fixed memory limit display in MemoryDataCollector
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Commits
    -------
    
    644f78d [HttpKernel] fixed memory limit display in MemoryDataCollector
  3. @hhamon
  4. @fabpot

    bug #9168 [FrameworkBundle] made sure that the debug event dispatcher…

    fabpot authored
    … is used everywhere (fabpot)
    
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] made sure that the debug event dispatcher is used everywhere
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #6686, #7673
    | License       | MIT
    | Doc PR        | n/a
    
    The removal of the Profiler dependency on the TraceableEventDispatcher (#9170) allows to remerge the patch from #9068 that fixes #6686.
    
    This PR also cleans up how profiles are stored. A Profile is now always stored only once.
    
    The fix will only be available on 2.4+ as the changes are too deep to be backported to 2.2 and 2.3.
    
    Commits
    -------
    
    1e1835e [FrameworkBundle] made sure that the debug event dispatcher is used everywhere
  5. @fabpot

    bug #9388 [Form] Fixed: The "data" option is taken into account even …

    fabpot authored
    …if it is NULL (bschussek)
    
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    [Form] Fixed: The "data" option is taken into account even if it is NULL
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    c1a3eb3 [Form] Fixed: The "data" option is taken into account even if it is NULL
  6. @fabpot

    bug #9394 [Form] Fixed form debugger to work even when no view variab…

    fabpot authored
    …les are logged (bschussek)
    
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    [Form] Fixed form debugger to work even when no view variables are logged
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #9331
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    99a4b7e [Form] Fixed form debugger to work even when no view variables are logged  (e.g. upon redirects)
  7. @webmozart

    [Form] Fixed form debugger to work even when no view variables are lo…

    webmozart authored
    …gged (e.g. upon redirects)
  8. @fabpot

    bug #9391 [Serializer] Fixed the error handling when decoding invalid…

    fabpot authored
    … XML to avoid a Warning (stof)
    
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    [Serializer] Fixed the error handling when decoding invalid XML to avoid a Warning
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Without the exception being thrown here, the call to ``simplexml_import_dom`` throws a warning saying ``Invalid Nodetype to import``.
    This has been reported by @Tobion after we refactored FOSRestBundle to use this XmlEncoder instead of a duplication of a previous version of the class: https://github.com/FriendsOfSymfony/FOSRestBundle/pull/583/files#r7221045
    
    Commits
    -------
    
    b2550b9 Fixed the error handling when decoding invalid XML to avoid a Warning
  9. @stof
  10. @asm89

    [FrameworkBundle] Update deprecation message

    asm89 authored
    Small addition to (doc string only):
    symfony#9252
  11. @webmozart
  12. @fabpot

    feature #9365 prevent PHP from magically setting a 302 header (lsmith77)

    fabpot authored
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    prevent PHP from magically setting a 302 header
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | yes (for people relying on getting a magic 302 when setting a Location header)
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    this needs a test case .. but first let me know if you are ok with this change.
    see http://www.php.net/manual/en/function.header.php
    
    Commits
    -------
    
    c140d4f prevent PHP from magically setting a 302 header, see http://www.php.net/manual/en/function.header.php
  13. @fabpot

    feature #9252 [FrameworkBundle] Only enable CSRF protection when enab…

    fabpot authored
    …led in config (asm89)
    
    This PR was squashed before being merged into the master branch (closes #9252).
    
    Discussion
    ----------
    
    [FrameworkBundle] Only enable CSRF protection when enabled in config
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | maybe?
    | Deprecations? | no
    | Tests pass?   | I hope, master was already broken here
    | License       | MIT
    
    symfony@bf85e83 introduced new service configuration for CSRF protection in the frameworkbundle. It is always enabled even if you don't use it. Since it also depends on enabling the session that's not so nice.
    
    Commits
    -------
    
    60dce14 [FrameworkBundle] Only enable CSRF protection when enabled in config
Something went wrong with that request. Please try again.