Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap elasticsearch gem for searchkick #1901

Merged
merged 42 commits into from Apr 18, 2019

Conversation

Projects
3 participants
@Br3nda
Copy link
Collaborator

commented Apr 1, 2019

the searchkick gem is simpler to use and has more features.
It provides some out of the box support for features that the official client does not (autocomplete, spelling suggestions, stemming, etc.).

https://docs.bonsai.io/article/99-searchkick

this PR swaps out the elasticsearch gem for searchkick and deletes a lot of code as a result.

closes #1610

New features:

  • find by alternate names
  • scientific names
  • misspellings
  • plurals
  • biased to crops you've planted
  • biased towards crops with higher planting counts

@Br3nda Br3nda requested review from maco, pmackay and CloCkWeRX Apr 1, 2019

@Br3nda Br3nda force-pushed the Br3nda:feature/searchkick branch from 2d7d8b2 to aa27205 Apr 1, 2019

@Br3nda Br3nda added this to Backlog in Growstuff Apr 8, 2019

@Br3nda Br3nda moved this from Backlog to In Progress in Growstuff Apr 8, 2019

@Br3nda Br3nda moved this from In Progress to Review in Growstuff Apr 8, 2019

@Br3nda Br3nda force-pushed the Br3nda:feature/searchkick branch from 5398882 to e165c77 Apr 8, 2019

Br3nda added some commits Apr 8, 2019

Br3nda added some commits Apr 12, 2019

@Br3nda Br3nda requested a review from cesy Apr 12, 2019

@Br3nda

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

It's working. Getting way more matches now, and i think the indexing and searching code it clearer to understand.

@Br3nda

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

That code climate fail is bogus. if you click through, there's no issues.

Br3nda added some commits Apr 13, 2019

@Br3nda Br3nda added this to the Release 51 milestone Apr 13, 2019

@Br3nda Br3nda requested review from milesgould and pozorvlak Apr 17, 2019

@CloCkWeRX
Copy link
Collaborator

left a comment

That all looks reasonable

@pozorvlak
Copy link
Member

left a comment

Looks great! Two typo fixes inline.

Show resolved Hide resolved Gemfile Outdated
Show resolved Hide resolved spec/services/crop_search_service_spec.rb Outdated
@pozorvlak

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

The conflict in Gemfile.lock looks straightforward enough, but I'm reluctant to hand-edit a generated file: @Br3nda, can you run bundle update to fix the conflict and then merge the PR once it's green?

pozorvlak and others added some commits Apr 18, 2019

Fixed comment
Co-Authored-By: Br3nda <brenda@wallace.net.nz>
Fix spelling of portobello
Co-Authored-By: Br3nda <brenda@wallace.net.nz>
@Br3nda

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 18, 2019

Added spec for biasing results to crops with higher planting counts, and crops the logged-in member has planted

@Br3nda Br3nda merged commit 5908d9f into Growstuff:dev Apr 18, 2019

3 checks passed

AccessLint Review complete
codeclimate 3 fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Growstuff automation moved this from Review to Done Apr 18, 2019

@Br3nda Br3nda deleted the Br3nda:feature/searchkick branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.