New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the creation of a garden with a negative number for the area. #452

Merged
merged 2 commits into from Nov 19, 2014

Conversation

Projects
None yet
2 participants
@wsmoak
Contributor

wsmoak commented Nov 19, 2014

Prevent the creation of a garden with a negative number for the area.
If entered, the area must be greater than or equal to zero.
Includes a test which fails without the patch.

Prevent the creation of a garden with a negative number for the area.…
… If entered, the area must be greater than or equal to zero.
@Skud

This comment has been minimized.

Show comment
Hide comment
@Skud

Skud Nov 19, 2014

Contributor

Lovely, thank you! As this is model code, can you also write a unit test for the validator under spec/models?

Contributor

Skud commented Nov 19, 2014

Lovely, thank you! As this is model code, can you also write a unit test for the validator under spec/models?

@wsmoak

This comment has been minimized.

Show comment
Hide comment
@wsmoak
Contributor

wsmoak commented Nov 19, 2014

@Skud

This comment has been minimized.

Show comment
Hide comment
@Skud

Skud Nov 19, 2014

Contributor

LGTM. Will merge after we do our production release PR.

Contributor

Skud commented Nov 19, 2014

LGTM. Will merge after we do our production release PR.

Skud added a commit that referenced this pull request Nov 19, 2014

Merge pull request #452 from wsmoak/negative-area
Prevent the creation of a garden with a negative number for the area.

@Skud Skud merged commit 6aea160 into Growstuff:dev Nov 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@wsmoak wsmoak deleted the wsmoak:negative-area branch Nov 19, 2014

@Skud Skud added this to the Release 7 milestone Dec 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment