New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add image to meta tag #739
Conversation
1 similar comment
Looks good, and I think [If the answer's "no, I'm not that comfortable with Ruby yet", no problem, we'd be happy to help you out!] |
Sure, will add the test! |
Great! |
I can't seem to get the tests to run locally, so not sure if I can write the test. Can someone else add it in? |
Sure, but I'd like to work out why you can't get the tests to run. Can you copy-and-paste the command you ran and the output you got here? |
Hi @ethulia, this looks good to me :) But as @pozovlak says, can you let us know which tests are failing for you so we can help you get that sorted out? Also, please add yourself to CONTRIBUTORS.md! |
@@ -1,6 +1,7 @@ | |||
%head | |||
<meta charset="utf-8" /> | |||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
<meta property="og:image" content="meta_image.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a small thing, but perhaps we could rename this something like growstuff_logo_ogimage.png or something? "meta_image" doesn't really tell us what it's for.
It looks like we merged someone else's fix to this issue, in #746 - sorry! Closing this as no longer needed :-( |
Pretty new to this, but an attempt at fixing #733
Let me know if the _meta.html file isn't the right place to put the tag!