New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcut for toggling transparency #117

Closed
kikecalpe opened this Issue Apr 30, 2013 · 17 comments

Comments

Projects
None yet
7 participants
@kikecalpe
Copy link

kikecalpe commented Apr 30, 2013

shortcut for toggling transparency http://guake.org/ticket/361
Reported by: snegawik Owned by: somebody
Priority: trivial Milestone:
Component: guake Version:
Keywords: Cc: bostonvaulter
Description

hey, it would be great if it would be possbible to toggle transparency by a shortcut, so I could toggle between 0% and the set value in the preferences(e.g.70%).

@pypingou

This comment has been minimized.

Copy link
Member

pypingou commented Apr 30, 2013

I don't think we will want to do this with guake.

If someone comes up with a patch we might reconsider (and even) so closing this request for now.

@pypingou pypingou closed this Apr 30, 2013

@gsemet gsemet modified the milestone: 0.5.1 Nov 3, 2014

@robrechtdr

This comment has been minimized.

Copy link

robrechtdr commented Nov 7, 2014

I don't think we will want to do this with guake.

Why not? This is super useful imo.

Suppose you are reading/experimenting with some api docs then summoning guake in transparent mode is really useful. Once done with the docs you can then toggle off transparency for increased visibility of the terminal text.

Perhaps you could introduce the concept of shell profiles like the gnome terminal has. But with the added option of setting a hotkey that toggles between two chosen profiles.

@gsemet

This comment has been minimized.

Copy link
Member

gsemet commented Nov 8, 2014

I am not against a Pull Request on this (simple to do), but it's not in short term roadmap

@gsemet gsemet modified the milestones: 1.1.0, 0.5.1 Nov 8, 2014

@gsemet gsemet reopened this Nov 8, 2014

@gsemet

This comment has been minimized.

Copy link
Member

gsemet commented Nov 8, 2014

Moved to long term version > 1y

@raghavrv

This comment has been minimized.

Copy link

raghavrv commented Sep 9, 2015

I really need this feature and am willing to help add this feature... Could someone help me in getting started?

@gsemet

This comment has been minimized.

Copy link
Member

gsemet commented Sep 10, 2015

you can hack the code, look for an existing shortcut and add your new one just aside of it :)

@thardev

This comment has been minimized.

Copy link
Contributor

thardev commented Oct 25, 2015

Hello @stibbons this is not already implemented?
transparency

@gsemet

This comment has been minimized.

Copy link
Member

gsemet commented Oct 25, 2015

indeed!

@gsemet gsemet closed this Oct 25, 2015

@raghavrv

This comment has been minimized.

Copy link

raghavrv commented Nov 4, 2015

That does an incremental transparency change not a toggle right?

@thardev

This comment has been minimized.

Copy link
Contributor

thardev commented Nov 4, 2015

Hello @rvraghav93!
Yeah, you are right, I understood this the wrong way, I'll work on it and in my next pull request it will be implemented 😄

@raghavrv

This comment has been minimized.

Copy link

raghavrv commented Nov 5, 2015

@thardev That would be awesome.. Thanks!

@thardev

This comment has been minimized.

Copy link
Contributor

thardev commented Nov 12, 2015

Hello @rvraghav93
I'm working on this but the way to implement it is not really clear for me, when you toggle the transparency it should be at its highest level (100%) and then when you toggle it again it should return to previous state? Is that the way?

@raghavrv

This comment has been minimized.

Copy link

raghavrv commented Nov 12, 2015

Yes that is what xterm2 (in mac) does IIRC... Thanks heaps for working on this!

thardev added a commit to thardev/guake that referenced this issue Dec 6, 2015

gsemet added a commit that referenced this issue Dec 29, 2015

Merge pull request #676 from thardev/master
Adds #117 feature shorcut toggle transparency

@gsemet gsemet modified the milestones: 3.1.0, 0.8.5 May 7, 2016

gsemet added a commit that referenced this issue Jan 30, 2017

Merge pull request #676 from thardev/master
Adds #117 feature shorcut toggle transparency

gsemet added a commit that referenced this issue Jan 30, 2017

Merge pull request #676 from thardev/master
Adds #117 feature shorcut toggle transparency
@jep-dev

This comment has been minimized.

Copy link

jep-dev commented Jan 25, 2018

I'm used to the behavior in Tilda and the transparency toggle seems a little odd to me here. When transparency is enabled at 30%, and you toggle it, why wouldn't the window be opaque? This seems to toggle opacity, not transparency. I normally keep the window around 30%, so I can read the window beneath an area of whitespace, but still read the text in the editor (at least over native windows and websites in night mode.) If your current theme is light-on-dark, 100% transparency makes everything in the terminal essentially unreadable, so you're better off toggling visibility instead. My current workaround is to increase/decrease the window transparency each time. Are there any plans to add configuration other than bgcolor/fgcolor to the command line arguments, or is there any way I could accomplish this another way?

@gsemet

This comment has been minimized.

Copy link
Member

gsemet commented Jan 25, 2018

From what i see, toggle transparence does not work

@gsemet

This comment has been minimized.

Copy link
Member

gsemet commented Jan 25, 2018

Restest again, work as expected. Toggle transparency toggles between user defined transparency and no transparency

@jep-dev

This comment has been minimized.

Copy link

jep-dev commented Jan 25, 2018

Ah, I was on the apt version when I thought I was on the repo. Thanks, looks fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment