Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Issue: Exposure of sensitive function, malicious user can arbitrary command via an execute_command d-bus method. #1796

Closed
junorouse opened this issue Sep 21, 2020 · 3 comments · Fixed by #2017

Comments

@junorouse
Copy link

junorouse commented Sep 21, 2020

Describe the bug

We understand that the usability of -e option. (#720)
BTW, it must not be exposured in d-bus interfaces.

Expected behavior

guake must not exposure execute_command in d-bus interfaces.

Do not exposure execute_command in d-bus interface.

Actual behavior

guake exposure execute_command in d-bus interface.

To Reproduce

We can use gdbus to call an execute_command d-bus method.

$ gdbus call -e -d org.guake3.RemoteControl -o /org/guake3/RemoteControl -m org.guake3.RemoteControl.execute_command "id > /tmp/1234"
$ cat /tmp/1234
uid=1000(juno) gid=1000(juno) groups=1000(juno),4(adm),20(dialout),21(fax),24(cdrom),25(floppy),26(tape),27(sudo),29(audio),30(dip),44(video),46(plugdev),100(users),109(netdev),112(bluetooth),115(lpadmin),117(scanner)

juno@abcd:/tmp/p/$ guake --support
Usage: guake [options]

guake: error: no such option: --support

cc. @bbb1g

@junorouse
Copy link
Author

junorouse commented Sep 21, 2020

And also execute_command_by_uuid is affected.

execute_command_by_uuid(in  s tab_uuid, in  s command);

Davidy22 added a commit to Davidy22/guake that referenced this issue Jan 21, 2022
Highlighted in Guake#1796. These changes orphan the execute_command_by_uuid() method, but the method can probably still be used elsewhere.
Davidy22 added a commit to Davidy22/guake that referenced this issue Jan 21, 2022
Highlighted in Guake#1796. Also removed comments that won't be true or relevant with this change. These changes orphan the execute_command_by_uuid() method, but the method can probably still be used elsewhere.
gsemet pushed a commit that referenced this issue Jan 27, 2022
Highlighted in #1796. Also removed comments that won't be true or relevant with this change. These changes orphan the execute_command_by_uuid() method, but the method can probably still be used elsewhere.
@ghostshadow
Copy link

Hi, it is nice, that you fix a potential security issue, but is there any concept for keeping the -e option working without the dbus call?
I use this option at a few places and would like to know now, if this option is going to be supported in the future or if i have to find another method for implementing my use cases.

@Davidy22
Copy link
Collaborator

Only the dbus call has been disconnected, -e is still a flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants