-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken link with badger::badge_codecov() - lack codecov token? #44
Comments
Been having the same issue myself for a while. Do you know what might be going on here @GuangchuangYu ? Thanks! |
Hi @GuangchuangYu @wleoncio @rossellhayes, was wondering if any of you (or any of the other Contributors) could speak to this? |
What happens if you hardcode both badger::badge_codecov("rcannood/princurve", branch = "master")
#> [1] "[![](https://app.codecov.io/gh/rcannood/princurve/branch/master/graph/badge.svg)](https://app.codecov.io/gh/rcannood/princurve)" Created on 2023-01-12 with reprex v2.0.2 |
Thanks for the reply @wleoncio Use case 1:
|
Ok, so I took a look at another repo of mine where the badge works. I don't remember how I figure this out, but dropping [![](https://codecov.io/gh/rcannood/princurve/branch/master/graph/badge.svg)](https://codecov.io/gh/rcannood/princurve) yields Doing the same for your repo also seems to work: [![](https://codecov.io/gh/neurogenomics/rworkflows/branch/master/graph/badge.svg)](https://codecov.io/gh/neurogenomics/rworkflows) outputs |
Ah, excellent! Thanks so much for this @wleoncio So it seems this is just a matter of |
Sure think, I'll issue the PR right away. As for the CRAN release, we're dependent on the maintainer (@GuangchuangYu). |
Awesome, thanks @wleoncio ! In the meantime, I'm wrapping a fix around the function when using it within my packages: gsub("app.codecov.io","codecov.io", ## fix domain name
badger::badge_codecov()
) |
Hi folks! Thanks for everyones efforts and investigations! Its been a while since I looked at this but the issue seemed to resolve itself when I just tried it again Using Recently I taught a Sorry I don't have any further issues and can't provide anything reproducible either at this stage so happy for the PR to go ahead! |
That's perfectly fine, thanks for the input! Fingers crossed the fix gets merged and published soon. :) |
merge and will be soon available on cran with v = 0.2.3. |
Hi @GuangchuangYu! Firstly, thank you for making such a convenient package! I use it regularly for package devs!
I am trying to establish a workflow for setting up:
use_coverage(type ="codecov")
test-coverage
usingusethis::use_github_action("test-coverage")
badger::badge_codecov(branch="gha")
Unfortunately when I use the output for
badger::badge_codecov(branch="gha")
e.g. d9e2987 in the README, the badge"shows "unknown: Knitting locally shows the same thing. However navigating to: https://codecov.io/gh/fontikar/ohwhaley/branch/gha/graph/badge.svg, gives me a perfect 100% badge.I then tried using the codecov badge found in the settings section of the repo which contains my codecov token
https://codecov.io/gh/fontikar/ohwhaley/branch/gha/graph/badge.svg?token=XXXXXXXX
and it was successful e.g. 701020dAm I missing a step? I tried adding the codecov token in my codecov.yaml but that didn't work either e.g. 7cd93db
Your advice would be greatly appreciated!
The text was updated successfully, but these errors were encountered: