Skip to content

/ hexSticker

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cairo and Enable Antialias When Saving Sticker on Windows #98

Merged
merged 6 commits into from Jun 1, 2020
Merged

Use Cairo and Enable Antialias When Saving Sticker on Windows #98

merged 6 commits into from Jun 1, 2020

Conversation

@thomas-neitmann
Copy link
Contributor

@thomas-neitmann thomas-neitmann commented May 30, 2020

This fixes the issue described in #97.
@thomas-neitmann
Use cairo to save png on Windows
eac0ff0
@thomas-neitmann
Import `graphics::plot()` to avoid note on R CMD check
ff13a96
@thomas-neitmann
Add Thomas Neitmann as contributor
ad3dd3c
@GuangchuangYu
Copy link
Owner

@GuangchuangYu GuangchuangYu commented Jun 1, 2020

thanks.

Your code introduces several new issues:

  1. ... was ignored
  2. user can export the sticker to other format except png in Windows

Can you solve them?
@thomas-neitmann
Use `ggsave()` to support exporting in different formats
7cb3aa0
@thomas-neitmann
Add details section to `sticker()`
0583881
@thomas-neitmann
Put filenames in quotes
bde2423
@GuangchuangYu GuangchuangYu merged commit 235955f into GuangchuangYu:master Jun 1, 2020
@GuangchuangYu
Copy link
Owner

@GuangchuangYu GuangchuangYu commented Jun 1, 2020

thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@thomas-neitmann @GuangchuangYu
You can’t perform that action at this time.